# HG changeset patch # User Jaroslav Tulach # Date 1213430103 -7200 # Node ID 920e95b470368bb1e8a61829a3a878330496ff75 # Parent 3611475f83db5bdd1d264ecbae570d4cf2ee1dc1 2nd batch of polishing of review2 diff -r 3611475f83db -r 920e95b47036 samples/apifest1/boolcircuit/nbproject/project.properties --- a/samples/apifest1/boolcircuit/nbproject/project.properties Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/apifest1/boolcircuit/nbproject/project.properties Sat Jun 14 09:55:03 2008 +0200 @@ -1,5 +1,3 @@ -application.title=boolcircuit -application.vendor=jarda build.classes.dir=${build.dir}/classes build.classes.excludes=**/*.java,**/*.form # This directory is removed when the project is cleaned: @@ -18,7 +16,6 @@ dist.jar=${dist.dir}/boolcircuit.jar dist.javadoc.dir=${dist.dir}/javadoc excludes= -file.reference.junit-4.4.jar=../../libs/dist/junit-4.4.jar includes=** jar.compress=false javac.classpath= @@ -30,7 +27,7 @@ javac.test.classpath=\ ${javac.classpath}:\ ${build.classes.dir}:\ - ${file.reference.junit-4.4.jar} + ${libs.junit.classpath} javadoc.additionalparam= javadoc.author=false javadoc.encoding= @@ -42,6 +39,9 @@ javadoc.use=true javadoc.version=false javadoc.windowtitle= +# Property libs.junit.classpath is set here just to make sharing of project simpler. +# The library definition has always preference over this property. +libs.junit.classpath=../../../../../usr/local/lib/netbeans/ide8/modules/ext/junit-3.8.2.jar meta.inf.dir=${src.dir}/META-INF platform.active=default_platform run.classpath=\ diff -r 3611475f83db -r 920e95b47036 samples/composition/build.xml --- a/samples/composition/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/composition/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - diff -r 3611475f83db -r 920e95b47036 samples/consistency/build.xml --- a/samples/consistency/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/consistency/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - diff -r 3611475f83db -r 920e95b47036 samples/delegatingwriterfinal/build.xml --- a/samples/delegatingwriterfinal/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/delegatingwriterfinal/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - diff -r 3611475f83db -r 920e95b47036 samples/differentreturntype/build.xml --- a/samples/differentreturntype/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/differentreturntype/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -25,7 +25,6 @@ - diff -r 3611475f83db -r 920e95b47036 samples/extensionpoint/build.xml --- a/samples/extensionpoint/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/extensionpoint/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - @@ -60,7 +59,7 @@ srcdir="src-${version}" destdir="build/${version}/classes" source="1.5" target="1.5" - classpath="${cp}:../libs/dist/org-openide-util.jar" + classpath="${cp}" /> diff -r 3611475f83db -r 920e95b47036 samples/forjoe/build.xml --- a/samples/forjoe/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/forjoe/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - diff -r 3611475f83db -r 920e95b47036 samples/friendpackage/nbproject/build-impl.xml --- a/samples/friendpackage/nbproject/build-impl.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/friendpackage/nbproject/build-impl.xml Sat Jun 14 09:55:03 2008 +0200 @@ -80,10 +80,7 @@ - - - - + @@ -97,27 +94,8 @@ - - - - - - - - - - - - - - - - - - - @@ -152,14 +130,15 @@ - + - + - + + @@ -196,12 +175,11 @@ - - + - + @@ -316,10 +294,8 @@ - + - - @@ -337,7 +313,7 @@ Must select some files in the IDE or set javac.includes - + @@ -420,10 +396,7 @@ - - - - + Must select one file in the IDE or set run.class @@ -451,7 +424,7 @@ Must select one file in the IDE or set debug.class - + Must set fix.includes @@ -467,10 +440,11 @@ --> - + + @@ -492,10 +466,8 @@ - + - - @@ -513,7 +485,7 @@ Must select some files in the IDE or set javac.includes - + @@ -532,7 +504,7 @@ - + Some tests failed; see details above. @@ -550,7 +522,7 @@ Some tests failed; see details above. - + Must select one file in the IDE or set test.class - - - - + - - - - + - + diff -r 3611475f83db -r 920e95b47036 samples/friendpackage/nbproject/project.properties --- a/samples/friendpackage/nbproject/project.properties Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/friendpackage/nbproject/project.properties Sat Jun 14 09:55:03 2008 +0200 @@ -1,5 +1,3 @@ -application.title=friendpackage -application.vendor=jarda build.classes.dir=${build.dir}/classes build.classes.excludes=**/*.java,**/*.form # This directory is removed when the project is cleaned: @@ -18,7 +16,6 @@ dist.jar=${dist.dir}/friendpackage.jar dist.javadoc.dir=${dist.dir}/javadoc excludes= -file.reference.junit-4.4.jar=../libs/dist/junit-4.4.jar includes=** jar.compress=false javac.classpath= @@ -30,7 +27,7 @@ javac.test.classpath=\ ${javac.classpath}:\ ${build.classes.dir}:\ - ${file.reference.junit-4.4.jar} + ${libs.junit.classpath} javadoc.additionalparam= javadoc.author=false javadoc.encoding= diff -r 3611475f83db -r 920e95b47036 samples/friendpackage/src/apipkg/Item.java --- a/samples/friendpackage/src/apipkg/Item.java Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/friendpackage/src/apipkg/Item.java Sat Jun 14 09:55:03 2008 +0200 @@ -28,7 +28,7 @@ // BEGIN: design.less.friend.Item.static static { - Accessor.setDefault(new AccessorImpl()); + Accessor.DEFAULT = new AccessorImpl(); } // END: design.less.friend.Item.static diff -r 3611475f83db -r 920e95b47036 samples/friendpackage/src/implpkg/Accessor.java --- a/samples/friendpackage/src/implpkg/Accessor.java Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/friendpackage/src/implpkg/Accessor.java Sat Jun 14 09:55:03 2008 +0200 @@ -22,27 +22,13 @@ */ // BEGIN: design.less.friend.Accessor public abstract class Accessor { - private static volatile Accessor DEFAULT; - public static Accessor getDefault() { - Accessor a = DEFAULT; - if (a != null) { - return a; - } - + public static Accessor DEFAULT; + static { try { Class.forName(Item.class.getName(), true, Item.class.getClassLoader()); } catch (Exception ex) { ex.printStackTrace(); } - - return DEFAULT; - } - - public static void setDefault(Accessor accessor) { - if (DEFAULT != null) { - throw new IllegalStateException(); - } - DEFAULT = accessor; } public Accessor() { diff -r 3611475f83db -r 920e95b47036 samples/friendpackage/test/implpkg/AccessorTest.java --- a/samples/friendpackage/test/implpkg/AccessorTest.java Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/friendpackage/test/implpkg/AccessorTest.java Sat Jun 14 09:55:03 2008 +0200 @@ -32,12 +32,18 @@ super(testName); } + protected void setUp() throws Exception { + } + + protected void tearDown() throws Exception { + } + public void testGetTheItemAttachListenerChangeValue() { // BEGIN: design.less.friend.use - Item item = Accessor.getDefault().newItem(); + Item item = Accessor.DEFAULT.newItem(); assertNotNull("Some item is really created", item); - Accessor.getDefault().addChangeListener(item, this); + Accessor.DEFAULT.addChangeListener(item, this); // END: design.less.friend.use item.setValue(10); diff -r 3611475f83db -r 920e95b47036 samples/growingparameters/build.xml --- a/samples/growingparameters/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/growingparameters/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - diff -r 3611475f83db -r 920e95b47036 samples/insertsuperclass/build.xml --- a/samples/insertsuperclass/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/insertsuperclass/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - diff -r 3611475f83db -r 920e95b47036 samples/instanceofclass/build.xml --- a/samples/instanceofclass/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/instanceofclass/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - diff -r 3611475f83db -r 920e95b47036 samples/messagedigest/build.xml --- a/samples/messagedigest/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/messagedigest/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - diff -r 3611475f83db -r 920e95b47036 samples/preventcyclicdependencies/build.xml --- a/samples/preventcyclicdependencies/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/preventcyclicdependencies/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - @@ -57,7 +56,7 @@ destdir="build/${version}/classes" source="1.5" target="1.5" debug="true" - classpath="${cp}:../libs/dist/org-openide-util.jar" + classpath="${cp}" /> diff -r 3611475f83db -r 920e95b47036 samples/primitiveconstants/build.xml --- a/samples/primitiveconstants/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/primitiveconstants/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ - diff -r 3611475f83db -r 920e95b47036 samples/reexport/build.xml --- a/samples/reexport/build.xml Sat Jun 14 09:55:02 2008 +0200 +++ b/samples/reexport/build.xml Sat Jun 14 09:55:03 2008 +0200 @@ -4,7 +4,6 @@ -