# HG changeset patch # User Jaroslav Tulach # Date 1344457524 -7200 # Node ID a72eecb999525a3af76a2f9a22faf0ea0b4fab9a # Parent 2eae47c2bfc3fdf8a39884b25eb667b395ee6262 Applying Andrei's suggestions: Using Arrays.asList diff -r 2eae47c2bfc3 -r a72eecb99952 samples/erasure/src-api1.0/api/Erasure.java --- a/samples/erasure/src-api1.0/api/Erasure.java Wed Aug 08 22:06:45 2012 +0200 +++ b/samples/erasure/src-api1.0/api/Erasure.java Wed Aug 08 22:25:24 2012 +0200 @@ -1,13 +1,13 @@ package api; -import java.util.Set; +import java.util.Collection; public class Erasure { private Erasure() { } // BEGIN: variance.erasure.v1 - public static boolean arePositive(Set numbers) { + public static boolean arePositive(Collection numbers) { for (Integer n : numbers) { if (n <= 0) { return false; diff -r 2eae47c2bfc3 -r a72eecb99952 samples/erasure/src-api2.0/api/Erasure.java --- a/samples/erasure/src-api2.0/api/Erasure.java Wed Aug 08 22:06:45 2012 +0200 +++ b/samples/erasure/src-api2.0/api/Erasure.java Wed Aug 08 22:25:24 2012 +0200 @@ -1,13 +1,13 @@ package api; -import java.util.Set; +import java.util.Collection; public class Erasure { private Erasure() { } // BEGIN: variance.erasure.v2 - public static boolean arePositive(Set numbers) { + public static boolean arePositive(Collection numbers) { for (Number n : numbers) { if (n.doubleValue() <= 0.0d) { return false; diff -r 2eae47c2bfc3 -r a72eecb99952 samples/erasure/src-impl/test/ErasureTest.java --- a/samples/erasure/src-impl/test/ErasureTest.java Wed Aug 08 22:06:45 2012 +0200 +++ b/samples/erasure/src-impl/test/ErasureTest.java Wed Aug 08 22:25:24 2012 +0200 @@ -1,18 +1,14 @@ package test; -import api.Erasure; -import java.util.Set; -import java.util.TreeSet; +import static api.Erasure.arePositive; +import java.util.Arrays; +import java.util.List; public class ErasureTest { // BEGIN: variance.erasure.test public static void main(String[] args) { - Set oneToTen = new TreeSet(); - for (int i = 1; i <= 10; i++) { - oneToTen.add(i); - } - - boolean positive = Erasure.arePositive(oneToTen); + List oneToTen = Arrays.asList(2, 4, 6, 8, 10); + boolean positive = arePositive(oneToTen); System.err.println("positive = " + positive); assert positive : "All the numbers are positive: " + oneToTen; }