# HG changeset patch
# User Jaroslav Tulach <jtulach@netbeans.org>
# Date 1251192730 -7200
# Node ID d5b6a877e5a8e6d620d6ab99a88e6719423d6ee0
# Parent  219810ff3c722f44096936c4ae97598a11e914f0
In fact builder pattern is combining mutable objects during creation with immutable result

diff -r 219810ff3c72 -r d5b6a877e5a8 samples/aserverinfo/nbproject/build-impl.xml
--- a/samples/aserverinfo/nbproject/build-impl.xml	Sat Jun 20 16:06:19 2009 +0200
+++ b/samples/aserverinfo/nbproject/build-impl.xml	Tue Aug 25 11:32:10 2009 +0200
@@ -20,6 +20,13 @@
 
         -->
 <project xmlns:j2seproject1="http://www.netbeans.org/ns/j2se-project/1" xmlns:j2seproject3="http://www.netbeans.org/ns/j2se-project/3" xmlns:jaxrpc="http://www.netbeans.org/ns/j2se-project/jax-rpc" basedir=".." default="default" name="aserverinfo-impl">
+    <fail message="Please build using Ant 1.7.1 or higher.">
+        <condition>
+            <not>
+                <antversion atleast="1.7.1"/>
+            </not>
+        </condition>
+    </fail>
     <target depends="test,jar,javadoc" description="Build and test whole project." name="default"/>
     <!-- 
                 ======================
@@ -152,10 +159,18 @@
             <attribute default="${includes}" name="includes"/>
             <attribute default="${excludes}" name="excludes"/>
             <attribute default="${javac.debug}" name="debug"/>
-            <attribute default="" name="sourcepath"/>
+            <attribute default="${empty.dir}" name="sourcepath"/>
+            <attribute default="${empty.dir}" name="gensrcdir"/>
             <element name="customize" optional="true"/>
             <sequential>
+                <property location="${build.dir}/empty" name="empty.dir"/>
+                <mkdir dir="${empty.dir}"/>
                 <javac debug="@{debug}" deprecation="${javac.deprecation}" destdir="@{destdir}" encoding="${source.encoding}" excludes="@{excludes}" includeantruntime="false" includes="@{includes}" source="${javac.source}" sourcepath="@{sourcepath}" srcdir="@{srcdir}" target="${javac.target}">
+                    <src>
+                        <dirset dir="@{gensrcdir}" erroronmissingdir="false">
+                            <include name="*"/>
+                        </dirset>
+                    </src>
                     <classpath>
                         <path path="@{classpath}"/>
                     </classpath>
@@ -271,6 +286,8 @@
                 <java classname="@{classname}" dir="${work.dir}" fork="true">
                     <jvmarg line="${debug-args-line}"/>
                     <jvmarg value="-Xrunjdwp:transport=${debug-transport},address=${jpda.address}"/>
+                    <jvmarg value="-Dfile.encoding=${source.encoding}"/>
+                    <redirector errorencoding="${source.encoding}" inputencoding="${source.encoding}" outputencoding="${source.encoding}"/>
                     <jvmarg line="${run.jvmargs}"/>
                     <classpath>
                         <path path="@{classpath}"/>
@@ -291,6 +308,8 @@
             <element name="customize" optional="true"/>
             <sequential>
                 <java classname="@{classname}" dir="${work.dir}" fork="true">
+                    <jvmarg value="-Dfile.encoding=${source.encoding}"/>
+                    <redirector errorencoding="${source.encoding}" inputencoding="${source.encoding}" outputencoding="${source.encoding}"/>
                     <jvmarg line="${run.jvmargs}"/>
                     <classpath>
                         <path path="@{classpath}"/>
@@ -317,7 +336,23 @@
                 COMPILATION SECTION
                 ===================
             -->
-    <target depends="init" name="deps-jar" unless="no.deps"/>
+    <target name="-deps-jar-init" unless="built-jar.properties">
+        <property location="${build.dir}/built-jar.properties" name="built-jar.properties"/>
+        <delete file="${built-jar.properties}" quiet="true"/>
+    </target>
+    <target depends="init,-deps-jar-init" name="deps-jar" unless="no.deps">
+        <mkdir dir="${build.dir}"/>
+        <touch file="${built-jar.properties}" verbose="false"/>
+        <property file="${built-jar.properties}" prefix="already.built.jar."/>
+        <fail message="Cycle detected: aserverinfo was already built">
+            <condition>
+                <isset property="already.built.jar.${basedir}"/>
+            </condition>
+        </fail>
+        <propertyfile file="${built-jar.properties}">
+            <entry key="${basedir}" value=""/>
+        </propertyfile>
+    </target>
     <target depends="init,-check-automatic-build,-clean-after-automatic-build" name="-verify-automatic-build"/>
     <target depends="init" name="-check-automatic-build">
         <available file="${build.classes.dir}/.netbeans_automatic_build" property="netbeans.automatic.build"/>
@@ -333,10 +368,15 @@
         <!-- You can override this target in the ../build.xml file. -->
     </target>
     <target if="do.depend.true" name="-compile-depend">
-        <j2seproject3:depend/>
+        <pathconvert property="build.generated.subdirs">
+            <dirset dir="${build.generated.sources.dir}" erroronmissingdir="false">
+                <include name="*"/>
+            </dirset>
+        </pathconvert>
+        <j2seproject3:depend srcdir="${src.dir}:${build.generated.subdirs}"/>
     </target>
     <target depends="init,deps-jar,-pre-pre-compile,-pre-compile,-compile-depend" if="have.sources" name="-do-compile">
-        <j2seproject3:javac/>
+        <j2seproject3:javac gensrcdir="${build.generated.sources.dir}"/>
         <copy todir="${build.classes.dir}">
             <fileset dir="${src.dir}" excludes="${build.classes.excludes},${excludes}" includes="${includes}"/>
         </copy>
@@ -353,7 +393,7 @@
     <target depends="init,deps-jar,-pre-pre-compile" name="-do-compile-single">
         <fail unless="javac.includes">Must select some files in the IDE or set javac.includes</fail>
         <j2seproject3:force-recompile/>
-        <j2seproject3:javac excludes="" includes="${javac.includes}" sourcepath="${src.dir}"/>
+        <j2seproject3:javac excludes="" gensrcdir="${build.generated.sources.dir}" includes="${javac.includes}" sourcepath="${src.dir}"/>
     </target>
     <target name="-post-compile-single">
         <!-- Empty placeholder for easier customization. -->
@@ -419,11 +459,29 @@
         <property location="${dist.jar}" name="dist.jar.resolved"/>
         <echo>java -jar "${dist.jar.resolved}"</echo>
     </target>
+    <target depends="init,compile,-pre-pre-jar,-pre-jar" if="libs.CopyLibs.classpath" name="-do-jar-with-libraries-without-manifest" unless="manifest.available+main.class">
+        <property location="${build.classes.dir}" name="build.classes.dir.resolved"/>
+        <pathconvert property="run.classpath.without.build.classes.dir">
+            <path path="${run.classpath}"/>
+            <map from="${build.classes.dir.resolved}" to=""/>
+        </pathconvert>
+        <pathconvert pathsep=" " property="jar.classpath">
+            <path path="${run.classpath.without.build.classes.dir}"/>
+            <chainedmapper>
+                <flattenmapper/>
+                <globmapper from="*" to="lib/*"/>
+            </chainedmapper>
+        </pathconvert>
+        <taskdef classname="org.netbeans.modules.java.j2seproject.copylibstask.CopyLibs" classpath="${libs.CopyLibs.classpath}" name="copylibs"/>
+        <copylibs compress="${jar.compress}" jarfile="${dist.jar}" runtimeclasspath="${run.classpath.without.build.classes.dir}">
+            <fileset dir="${build.classes.dir}"/>
+        </copylibs>
+    </target>
     <target name="-post-jar">
         <!-- Empty placeholder for easier customization. -->
         <!-- You can override this target in the ../build.xml file. -->
     </target>
-    <target depends="init,compile,-pre-jar,-do-jar-with-manifest,-do-jar-without-manifest,-do-jar-with-mainclass,-do-jar-with-libraries,-post-jar" description="Build JAR." name="jar"/>
+    <target depends="init,compile,-pre-jar,-do-jar-with-manifest,-do-jar-without-manifest,-do-jar-with-mainclass,-do-jar-with-libraries,-do-jar-with-libraries-without-manifest,-post-jar" description="Build JAR." name="jar"/>
     <!--
                 =================
                 EXECUTION SECTION
@@ -502,6 +560,9 @@
             <fileset dir="${src.dir}" excludes="${excludes}" includes="${includes}">
                 <filename name="**/*.java"/>
             </fileset>
+            <fileset dir="${build.generated.sources.dir}" erroronmissingdir="false">
+                <include name="**/*.java"/>
+            </fileset>
         </javadoc>
     </target>
     <target depends="init,-javadoc-build" if="netbeans.home" name="-javadoc-browse" unless="no.javadoc.preview">
@@ -563,7 +624,7 @@
         <j2seproject3:junit testincludes="**/*Test.java"/>
     </target>
     <target depends="init,compile-test,-pre-test-run,-do-test-run" if="have.tests" name="-post-test-run">
-        <fail if="tests.failed">Some tests failed; see details above.</fail>
+        <fail if="tests.failed" unless="ignore.failing.tests">Some tests failed; see details above.</fail>
     </target>
     <target depends="init" if="have.tests" name="test-report"/>
     <target depends="init" if="netbeans.home+have.tests" name="-test-browse"/>
@@ -576,7 +637,7 @@
         <j2seproject3:junit excludes="" includes="${test.includes}"/>
     </target>
     <target depends="init,compile-test-single,-pre-test-run-single,-do-test-run-single" if="have.tests" name="-post-test-run-single">
-        <fail if="tests.failed">Some tests failed; see details above.</fail>
+        <fail if="tests.failed" unless="ignore.failing.tests">Some tests failed; see details above.</fail>
     </target>
     <target depends="init,-do-not-recompile,compile-test-single,-pre-test-run-single,-do-test-run-single,-post-test-run-single" description="Run single unit test." name="test-single"/>
     <!--
@@ -642,7 +703,23 @@
                 CLEANUP SECTION
                 ===============
             -->
-    <target depends="init" name="deps-clean" unless="no.deps"/>
+    <target name="-deps-clean-init" unless="built-clean.properties">
+        <property location="${build.dir}/built-clean.properties" name="built-clean.properties"/>
+        <delete file="${built-clean.properties}" quiet="true"/>
+    </target>
+    <target depends="init,-deps-clean-init" name="deps-clean" unless="no.deps">
+        <mkdir dir="${build.dir}"/>
+        <touch file="${built-clean.properties}" verbose="false"/>
+        <property file="${built-clean.properties}" prefix="already.built.clean."/>
+        <fail message="Cycle detected: aserverinfo was already built">
+            <condition>
+                <isset property="already.built.clean.${basedir}"/>
+            </condition>
+        </fail>
+        <propertyfile file="${built-clean.properties}">
+            <entry key="${basedir}" value=""/>
+        </propertyfile>
+    </target>
     <target depends="init" name="-do-clean">
         <delete dir="${build.dir}"/>
         <delete dir="${dist.dir}"/>
@@ -652,4 +729,20 @@
         <!-- You can override this target in the ../build.xml file. -->
     </target>
     <target depends="init,deps-clean,-do-clean,-post-clean" description="Clean build products." name="clean"/>
+    <target name="-check-call-dep">
+        <property file="${call.built.properties}" prefix="already.built."/>
+        <condition property="should.call.dep">
+            <not>
+                <isset property="already.built.${call.subproject}"/>
+            </not>
+        </condition>
+    </target>
+    <target depends="-check-call-dep" if="should.call.dep" name="-maybe-call-dep">
+        <ant antfile="${call.script}" inheritall="false" target="${call.target}">
+            <propertyset>
+                <propertyref prefix="transfer."/>
+                <mapper from="transfer.*" to="*" type="glob"/>
+            </propertyset>
+        </ant>
+    </target>
 </project>
diff -r 219810ff3c72 -r d5b6a877e5a8 samples/aserverinfo/nbproject/genfiles.properties
--- a/samples/aserverinfo/nbproject/genfiles.properties	Sat Jun 20 16:06:19 2009 +0200
+++ b/samples/aserverinfo/nbproject/genfiles.properties	Tue Aug 25 11:32:10 2009 +0200
@@ -4,5 +4,5 @@
 # This file is used by a NetBeans-based IDE to track changes in generated files such as build-impl.xml.
 # Do not edit this file. You may delete it but then the IDE will never regenerate such files for you.
 nbproject/build-impl.xml.data.CRC32=c82747ea
-nbproject/build-impl.xml.script.CRC32=1033418a
-nbproject/build-impl.xml.stylesheet.CRC32=84d9cdb5
+nbproject/build-impl.xml.script.CRC32=c7c23170
+nbproject/build-impl.xml.stylesheet.CRC32=29e56e74@1.29.0.45
diff -r 219810ff3c72 -r d5b6a877e5a8 samples/aserverinfo/nbproject/project.properties
--- a/samples/aserverinfo/nbproject/project.properties	Sat Jun 20 16:06:19 2009 +0200
+++ b/samples/aserverinfo/nbproject/project.properties	Tue Aug 25 11:32:10 2009 +0200
@@ -3,6 +3,7 @@
 # This directory is removed when the project is cleaned:
 build.dir=build
 build.generated.dir=${build.dir}/generated
+build.generated.sources.dir=${build.dir}/generated-sources
 # Only compile against the classpath explicitly listed here:
 build.sysclasspath=ignore
 build.test.classes.dir=${build.dir}/test/classes
diff -r 219810ff3c72 -r d5b6a877e5a8 samples/aserverinfo/src/org/apidesign/aserverinfo/builder/ServerInfo.java
--- a/samples/aserverinfo/src/org/apidesign/aserverinfo/builder/ServerInfo.java	Sat Jun 20 16:06:19 2009 +0200
+++ b/samples/aserverinfo/src/org/apidesign/aserverinfo/builder/ServerInfo.java	Tue Aug 25 11:32:10 2009 +0200
@@ -6,7 +6,7 @@
 import org.apidesign.aserverinfo.spi.URLProvider;
 
 /**
- * Cumulative factory methods for the builder pattern
+ * Mutable "setter" methods for the builder pattern.
  *
  * @author Jaroslav Tulach <jtulach@netbeans.org>
  */
@@ -18,15 +18,21 @@
     }
 
     public final ServerInfo nameProvider(NameProvider np) {
-        return new ServerInfo(np, this.url, this.reset, this.shutdown);
+        this.name = np;
+        return this;
     }
 
     public final ServerInfo urlProvider(URLProvider up) {
-        return new ServerInfo(this.name, up, this.reset, this.shutdown);
+        this.url = up;
+        return this;
     }
+    // BEGIN: aserverinfo.builder.setter
     public final ServerInfo reset(ResetHandler h) {
-        return new ServerInfo(this.name, this.url, h, this.shutdown);
+        this.reset = h;
+        return this;
     }
+    // END: aserverinfo.builder.setter
+    
     /** All one needs to do when there is a need to add new
      * style of creation is to add new method for a builder.
      * @param handler
@@ -34,7 +40,8 @@
      * @since 2.0
      */
     public final ServerInfo shutdown(ShutdownHandler handler) {
-        return new ServerInfo(this.name, this.url, this.reset, handler);
+        this.shutdown = handler;
+        return this;
     }
     
     /** Creates the server connector based on current values in the 
@@ -46,10 +53,10 @@
     }
     // FINISH: aserverinfo.builder.factory
 
-    private final NameProvider name;
-    private final URLProvider url;
-    private final ResetHandler reset;
-    private final ShutdownHandler shutdown;
+    private NameProvider name;
+    private URLProvider url;
+    private ResetHandler reset;
+    private ShutdownHandler shutdown;
 
     private ServerInfo(
         NameProvider name, URLProvider url,
diff -r 219810ff3c72 -r d5b6a877e5a8 samples/aserverinfo/test/org/apidesign/aserverinfo/test/BuilderFactoryTest.java
--- a/samples/aserverinfo/test/org/apidesign/aserverinfo/test/BuilderFactoryTest.java	Sat Jun 20 16:06:19 2009 +0200
+++ b/samples/aserverinfo/test/org/apidesign/aserverinfo/test/BuilderFactoryTest.java	Tue Aug 25 11:32:10 2009 +0200
@@ -32,16 +32,16 @@
         NameProvider np = p;
         URLProvider up = p;
         ResetHandler res = p;
-        ServerConnector inf;
+        ServerConnector connection;
         
         // BEGIN: ServerConnector.builder.creation
-        inf = ServerInfo.empty()
+        connection = ServerInfo.empty()
                 .nameProvider(np).urlProvider(up).reset(res).connect();
         // END: ServerConnector.builder.creation
         
-        assertEquals("API Design Server", inf.getName());
-        assertEquals("http://www.apidesign.org", inf.getURL().toExternalForm());
-        inf.reset();
+        assertEquals("API Design Server", connection.getName());
+        assertEquals("http://www.apidesign.org", connection.getURL().toExternalForm());
+        connection.reset();
         assertEquals("Once reset", 1, p.resets);
         
     }
@@ -49,19 +49,19 @@
     @Test
     public void showVerboseUseOfBuilder() throws Exception {
         Prov prov = new Prov();
-        ServerConnector info;
+        ServerConnector connection;
         
         // BEGIN: ServerConnector.builder.creation.verbose
         ServerInfo empty = ServerInfo.empty();
         ServerInfo name = empty.nameProvider(prov);
         ServerInfo urlAndName = name.urlProvider(prov);
         ServerInfo all = urlAndName.reset(prov);
-        info = all.connect();
+        connection = all.connect();
         // END: ServerConnector.builder.creation.verbose
         
-        assertEquals("API Design Server", info.getName());
-        assertEquals("http://www.apidesign.org", info.getURL().toExternalForm());
-        info.reset();
+        assertEquals("API Design Server", connection.getName());
+        assertEquals("http://www.apidesign.org", connection.getURL().toExternalForm());
+        connection.reset();
         assertEquals("Once reset", 1, prov.resets);
         
     }