new Boolean() considered harmful. Boolean.TRUE, Boolean.FALSE, or release34_base
authorttran@netbeans.org
Sun, 15 Sep 2002 20:22:33 +0000
changeset 2552cfc7a5bd85aa
parent 2551 d09b12212f7c
child 2553 1e0249c77f3e
new Boolean() considered harmful. Boolean.TRUE, Boolean.FALSE, or
Boolean.valueOf() should be used instead. See JDK 1.4 Boolean
constructor's javadoc or "Effective Java" book for why.
clazz/src/org/netbeans/modules/clazz/ClassDataNode.java
clazz/src/org/netbeans/modules/clazz/ClassDataObject.java
clazz/src/org/netbeans/modules/clazz/CompiledDataNode.java
corba/src/org/netbeans/modules/corba/idl/src/IDLParser.java
corba/src/org/netbeans/modules/corba/ioranalyzer/ProfileChildren.java
corba/src/org/netbeans/modules/corba/utils/FullBeanContextSupport.java
corba/src/org/netbeans/modules/corba/wizard/nodes/gui/ExPanel.java
corba/src/org/netbeans/modules/corba/wizard/panels/PackagePanel.java
jemmysupport/src/org/netbeans/modules/jemmysupport/bundlelookup/BundleLookupPanel.java
remotefs/src/org/netbeans/modules/remotefs/core/ManagedRemoteFileSystem.java
remotefs/src/org/netbeans/modules/remotefs/core/RemoteFileSystem.java
remotefs/src/org/netbeans/modules/remotefs/ftpfs/FTPSettings.java
rmi/test/qa-functional/src/rmitests/RMIApiTests.java
rmi/test/qa-functional/src/support/Support.java
vcs.advanced/src/org/netbeans/modules/vcs/advanced/CommandLineVcsFileSystem.java
vcs.advanced/src/org/netbeans/modules/vcs/advanced/CommandLineVcsFileSystemBeanInfo.java
vcs.advanced/src/org/netbeans/modules/vcs/advanced/VcsCustomizer.java
vcs.advanced/src/org/netbeans/modules/vcs/advanced/commands/UserCommandIOCompat.java
vcs.advanced/src/org/netbeans/modules/vcs/advanced/variables/AccessoryVariableNode.java
vcs.advanced/src/org/netbeans/modules/vcs/advanced/variables/BasicVariableNode.java
vcs.advanced/src/org/netbeans/modules/vcs/profiles/list/AbstractListCommand.java
vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsModuleParser.java
vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsWatchStatus.java
vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/list/CvsListFileCommand.java
vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/list/CvsListRecursiveCommand.java
vcscore/src/org/netbeans/modules/vcscore/VcsAttributes.java
vcscore/src/org/netbeans/modules/vcscore/VcsFileSystem.java
vcscore/src/org/netbeans/modules/vcscore/VcsVersioningSystem.java
vcscore/src/org/netbeans/modules/vcscore/VcsVersioningSystemBeanInfo.java
vcscore/src/org/netbeans/modules/vcscore/cmdline/UserCommand.java
vcscore/src/org/netbeans/modules/vcscore/commands/PreCommandPerformer.java
vcscore/src/org/netbeans/modules/vcscore/grouping/VcsGroupSettings.java
vcscore/src/org/netbeans/modules/vcscore/settings/GeneralVcsSettings.java
vcscore/src/org/netbeans/modules/vcscore/ui/views/NodesTableView.java
vcscore/src/org/netbeans/modules/vcscore/ui/views/SingleNodeView.java
vcscore/src/org/netbeans/modules/vcscore/ui/views/TableView.java
vcscore/src/org/netbeans/modules/vcscore/util/VariableInputDialog.java
vcscore/src/org/netbeans/modules/vcscore/util/table/TableInfoModel.java
vcscore/src/org/netbeans/modules/vcscore/versioning/RevisionItem.java
     1.1 --- a/clazz/src/org/netbeans/modules/clazz/ClassDataNode.java	Sat Sep 14 18:48:21 2002 +0000
     1.2 +++ b/clazz/src/org/netbeans/modules/clazz/ClassDataNode.java	Sun Sep 15 20:22:33 2002 +0000
     1.3 @@ -149,7 +149,7 @@
     1.4                     bundle.getString ("HINT_isInterface")
     1.5                 ) {
     1.6                     public Object getValue () throws InvocationTargetException {
     1.7 -                       return new Boolean (obj.isInterface());
     1.8 +                       return obj.isInterface() ? Boolean.TRUE : Boolean.FALSE;
     1.9                     }
    1.10                 });
    1.11          ps.put(new PropertySupport.ReadOnly (
    1.12 @@ -159,7 +159,7 @@
    1.13                     bundle.getString ("HINT_isApplet")
    1.14                 ) {
    1.15                     public Object getValue () throws InvocationTargetException {
    1.16 -                       return new Boolean (obj.isApplet());
    1.17 +                       return obj.isApplet() ? Boolean.TRUE : Boolean.FALSE;
    1.18                     }
    1.19                 });
    1.20          ps.put(new PropertySupport.ReadOnly (
    1.21 @@ -169,7 +169,7 @@
    1.22                     bundle.getString ("HINT_isJavaBean")
    1.23                 ) {
    1.24                     public Object getValue () throws InvocationTargetException {
    1.25 -                       return new Boolean (obj.isJavaBean());
    1.26 +                       return obj.isJavaBean() ? Boolean.TRUE : Boolean.FALSE;
    1.27                     }
    1.28                 });
    1.29          return s;
     2.1 --- a/clazz/src/org/netbeans/modules/clazz/ClassDataObject.java	Sat Sep 14 18:48:21 2002 +0000
     2.2 +++ b/clazz/src/org/netbeans/modules/clazz/ClassDataObject.java	Sun Sep 15 20:22:33 2002 +0000
     2.3 @@ -647,7 +647,7 @@
     2.4              if (executable == null) {
     2.5                  ClassElement ce=getMainClass();
     2.6  
     2.7 -                executable=new Boolean((ce==null)?false:ce.hasMainMethod());
     2.8 +                executable = ((ce==null) ? false : ce.hasMainMethod()) ? Boolean.TRUE : Boolean.FALSE;
     2.9              }
    2.10              return executable.booleanValue ();
    2.11          }    
     3.1 --- a/clazz/src/org/netbeans/modules/clazz/CompiledDataNode.java	Sat Sep 14 18:48:21 2002 +0000
     3.2 +++ b/clazz/src/org/netbeans/modules/clazz/CompiledDataNode.java	Sun Sep 15 20:22:33 2002 +0000
     3.3 @@ -74,7 +74,7 @@
     3.4                     bundle.getString ("HINT_isExecutable")
     3.5                 ) {
     3.6                     public Object getValue () throws InvocationTargetException {
     3.7 -                       return new Boolean(getCompiledDataObject().isExecutable());
     3.8 +                       return getCompiledDataObject().isExecutable() ? Boolean.TRUE : Boolean.FALSE;
     3.9                     }
    3.10                 });
    3.11          ExecSupport es = (ExecSupport)getCookie(ExecSupport.class);
     4.1 --- a/corba/src/org/netbeans/modules/corba/idl/src/IDLParser.java	Sat Sep 14 18:48:21 2002 +0000
     4.2 +++ b/corba/src/org/netbeans/modules/corba/idl/src/IDLParser.java	Sun Sep 15 20:22:33 2002 +0000
     4.3 @@ -506,7 +506,7 @@
     4.4      Vector inter = new Vector ();
     4.5      Identifier name;
     4.6      Vector inher;
     4.7 -    Boolean abs = new Boolean (false);
     4.8 +    Boolean abs = Boolean.FALSE;
     4.9        switch ((jj_ntk==-1)?jj_ntk():jj_ntk) {
    4.10        case 14:
    4.11          jj_consume_token(14);
     5.1 --- a/corba/src/org/netbeans/modules/corba/ioranalyzer/ProfileChildren.java	Sat Sep 14 18:48:21 2002 +0000
     5.2 +++ b/corba/src/org/netbeans/modules/corba/ioranalyzer/ProfileChildren.java	Sun Sep 15 20:22:33 2002 +0000
     5.3 @@ -121,7 +121,7 @@
     5.4          boolean valid = true;
     5.5          try {
     5.6              lazyInit();
     5.7 -            return new Boolean (this.iorData.isLittleEndian());
     5.8 +            return this.iorData.isLittleEndian() ? Boolean.TRUE : Boolean.FALSE;
     5.9          }catch (org.omg.CORBA.BAD_PARAM bp) {
    5.10              valid = false;
    5.11              return null;
     6.1 --- a/corba/src/org/netbeans/modules/corba/utils/FullBeanContextSupport.java	Sat Sep 14 18:48:21 2002 +0000
     6.2 +++ b/corba/src/org/netbeans/modules/corba/utils/FullBeanContextSupport.java	Sun Sep 15 20:22:33 2002 +0000
     6.3 @@ -226,7 +226,7 @@
     6.4      public void setDesignTime(boolean param) {
     6.5          boolean oldValue = this.isDesignTime;
     6.6          this.isDesignTime = param;
     6.7 -        firePropertyChange (DESIGN_MODE,new Boolean(oldValue),new Boolean(this.isDesignTime));
     6.8 +        firePropertyChange (DESIGN_MODE,oldValue ? Boolean.TRUE : Boolean.FALSE,this.isDesignTime ? Boolean.TRUE : Boolean.FALSE);
     6.9      }
    6.10      
    6.11      public synchronized boolean add (Object element) {
     7.1 --- a/corba/src/org/netbeans/modules/corba/wizard/nodes/gui/ExPanel.java	Sat Sep 14 18:48:21 2002 +0000
     7.2 +++ b/corba/src/org/netbeans/modules/corba/wizard/nodes/gui/ExPanel.java	Sun Sep 15 20:22:33 2002 +0000
     7.3 @@ -44,22 +44,22 @@
     7.4      }
     7.5      
     7.6      public void enableOk () {
     7.7 -        PropertyChangeEvent event = new PropertyChangeEvent (this,"Ok",null, new Boolean(true));  //No I18N
     7.8 +        PropertyChangeEvent event = new PropertyChangeEvent (this,"Ok",null, Boolean.TRUE);  //No I18N
     7.9          this.listeners.firePropertyChange (event);
    7.10      }
    7.11      
    7.12      public void disableOk () {
    7.13 -        PropertyChangeEvent event = new PropertyChangeEvent (this,"Ok",null, new Boolean(false));  //No I18N
    7.14 +        PropertyChangeEvent event = new PropertyChangeEvent (this,"Ok",null, Boolean.FALSE);  //No I18N
    7.15          this.listeners.firePropertyChange (event);
    7.16      }
    7.17      
    7.18      public void enableCancel () {
    7.19 -        PropertyChangeEvent event = new PropertyChangeEvent (this,"Cancel",new Boolean(true),null);  //No I18N
    7.20 +        PropertyChangeEvent event = new PropertyChangeEvent (this,"Cancel",Boolean.TRUE,null);  //No I18N
    7.21          this.listeners.firePropertyChange (event);
    7.22      }
    7.23      
    7.24      public void disableCancel () {
    7.25 -        PropertyChangeEvent event = new PropertyChangeEvent (this,"Cancel",new Boolean(false),null);  //No I18N
    7.26 +        PropertyChangeEvent event = new PropertyChangeEvent (this,"Cancel",Boolean.FALSE,null);  //No I18N
    7.27          this.listeners.firePropertyChange (event);
    7.28      }
    7.29  
     8.1 --- a/corba/src/org/netbeans/modules/corba/wizard/panels/PackagePanel.java	Sat Sep 14 18:48:21 2002 +0000
     8.2 +++ b/corba/src/org/netbeans/modules/corba/wizard/panels/PackagePanel.java	Sun Sep 15 20:22:33 2002 +0000
     8.3 @@ -67,9 +67,9 @@
     8.4          this.tree.getExplorerManager().addPropertyChangeListener (this);
     8.5          this.tree.getExplorerManager().addVetoableChangeListener (this);
     8.6          this.idlName.getDocument().addDocumentListener(this);
     8.7 -        putClientProperty(CorbaWizard.PROP_AUTO_WIZARD_STYLE, new Boolean(true));
     8.8 -        putClientProperty(CorbaWizard.PROP_CONTENT_DISPLAYED, new Boolean(true));
     8.9 -        putClientProperty(CorbaWizard.PROP_CONTENT_NUMBERED, new Boolean(true));
    8.10 +        putClientProperty(CorbaWizard.PROP_AUTO_WIZARD_STYLE, Boolean.TRUE);
    8.11 +        putClientProperty(CorbaWizard.PROP_CONTENT_DISPLAYED, Boolean.TRUE);
    8.12 +        putClientProperty(CorbaWizard.PROP_CONTENT_NUMBERED, Boolean.TRUE);
    8.13          putClientProperty(CorbaWizard.PROP_CONTENT_SELECTED_INDEX, new Integer(0));
    8.14          putClientProperty(CorbaWizard.PROP_CONTENT_DATA, new String[] {
    8.15              bundle.getString("TXT_Source"),
     9.1 --- a/jemmysupport/src/org/netbeans/modules/jemmysupport/bundlelookup/BundleLookupPanel.java	Sat Sep 14 18:48:21 2002 +0000
     9.2 +++ b/jemmysupport/src/org/netbeans/modules/jemmysupport/bundlelookup/BundleLookupPanel.java	Sun Sep 15 20:22:33 2002 +0000
     9.3 @@ -78,7 +78,7 @@
     9.4                      ascOrder.remove(i);
     9.5                  }
     9.6                  sortOrder.add(0, new Integer(column));
     9.7 -                ascOrder.add(0, new Boolean(asc));
     9.8 +                ascOrder.add(0, asc ? Boolean.TRUE : Boolean.FALSE);
     9.9              }
    9.10              public synchronized int compare(Object obj, Object obj1) {
    9.11                  if (obj instanceof Vector)
    10.1 --- a/remotefs/src/org/netbeans/modules/remotefs/core/ManagedRemoteFileSystem.java	Sat Sep 14 18:48:21 2002 +0000
    10.2 +++ b/remotefs/src/org/netbeans/modules/remotefs/core/ManagedRemoteFileSystem.java	Sun Sep 15 20:22:33 2002 +0000
    10.3 @@ -139,7 +139,7 @@
    10.4      //refreshRoot();
    10.5      //try { org.openide.loaders.DataObject.find(super.getRoot()).getNodeDelegate().setDisplayName(getDisplayName()); }
    10.6      //catch (org.openide.loaders.DataObjectNotFoundException e) {}
    10.7 -    firePropertyChange("connected", null, new Boolean(isConnected()));
    10.8 +    firePropertyChange("connected", null, isConnected() ? Boolean.TRUE : Boolean.FALSE);
    10.9      //firePropertyChange(PROP_SYSTEM_NAME, "", getSystemName());
   10.10    }
   10.11    
    11.1 --- a/remotefs/src/org/netbeans/modules/remotefs/core/RemoteFileSystem.java	Sat Sep 14 18:48:21 2002 +0000
    11.2 +++ b/remotefs/src/org/netbeans/modules/remotefs/core/RemoteFileSystem.java	Sun Sep 15 20:22:33 2002 +0000
    11.3 @@ -220,7 +220,7 @@
    11.4      //refreshRoot();
    11.5      //try { org.openide.loaders.DataObject.find(super.getRoot()).getNodeDelegate().setDisplayName(getDisplayName()); }
    11.6      //catch (org.openide.loaders.DataObjectNotFoundException e) {}
    11.7 -    firePropertyChange("connected", null, new Boolean(isConnected()));
    11.8 +    firePropertyChange("connected", null, isConnected() ? Boolean.TRUE : Boolean.FALSE);
    11.9      //firePropertyChange(PROP_SYSTEM_NAME, "", getSystemName());
   11.10    }
   11.11  
   11.12 @@ -248,7 +248,7 @@
   11.13    public void setReadOnly(boolean flag) {
   11.14      if (flag != readOnly) {
   11.15        readOnly = flag;
   11.16 -      firePropertyChange (PROP_READ_ONLY, new Boolean (!flag), new Boolean (flag));
   11.17 +      firePropertyChange (PROP_READ_ONLY, !flag ? Boolean.TRUE : Boolean.FALSE, flag ? Boolean.TRUE : Boolean.FALSE);
   11.18      }
   11.19    }
   11.20  
    12.1 --- a/remotefs/src/org/netbeans/modules/remotefs/ftpfs/FTPSettings.java	Sat Sep 14 18:48:21 2002 +0000
    12.2 +++ b/remotefs/src/org/netbeans/modules/remotefs/ftpfs/FTPSettings.java	Sun Sep 15 20:22:33 2002 +0000
    12.3 @@ -170,7 +170,7 @@
    12.4    public void setPassiveMode(boolean passiveMode) {
    12.5      boolean old = this.passiveMode;
    12.6      this.passiveMode = passiveMode;
    12.7 -    firePropertyChange(PROP_PASSIVE_MODE,new Boolean(old),new Boolean(this.passiveMode));
    12.8 +    firePropertyChange(PROP_PASSIVE_MODE,old ? Boolean.TRUE : Boolean.FALSE,this.passiveMode ? Boolean.TRUE : Boolean.FALSE);
    12.9    }
   12.10    /** Getter for property askCacheExternalDelete.
   12.11     * @return Value of property askCacheExternalDelete.
    13.1 --- a/rmi/test/qa-functional/src/rmitests/RMIApiTests.java	Sat Sep 14 18:48:21 2002 +0000
    13.2 +++ b/rmi/test/qa-functional/src/rmitests/RMIApiTests.java	Sun Sep 15 20:22:33 2002 +0000
    13.3 @@ -720,12 +720,12 @@
    13.4                  if (((Boolean)(prop.getValue())).booleanValue()) log(bundle.getString("Module_RMI_instaled.")); else log(bundle.getString("Module_RMI_not_instaled."));
    13.5                  log(bundle.getString("Uninstaling_module_RMI"));
    13.6                  //unistaling module RMI
    13.7 -                prop.setValue(new Boolean(false));
    13.8 +                prop.setValue(Boolean.FALSE);
    13.9                  sup.sleep(5000);
   13.10                  if (((Boolean)(prop.getValue())).booleanValue()) log(bundle.getString("Module_RMI_not_uninstaled.")); else log(bundle.getString("Module_RMI_uninstaled."));
   13.11                  log(bundle.getString("Instaling_module_RMI"));
   13.12                  //istaling module RMI
   13.13 -                prop.setValue(new Boolean(true));
   13.14 +                prop.setValue(Boolean.TRUE);
   13.15                  sup.sleep(5000);
   13.16                  if (((Boolean)(prop.getValue())).booleanValue()) log(bundle.getString("Module_RMI_instaled.")); else log(bundle.getString("Module_RMI_not_instaled."));
   13.17              } else log(bundle.getString("Wrong_property_")+prop.getName());
    14.1 --- a/rmi/test/qa-functional/src/support/Support.java	Sat Sep 14 18:48:21 2002 +0000
    14.2 +++ b/rmi/test/qa-functional/src/support/Support.java	Sun Sep 15 20:22:33 2002 +0000
    14.3 @@ -117,7 +117,7 @@
    14.4          Class c[]={org.netbeans.modules.java.JavaDataObject.class, Boolean.TYPE};
    14.5          java.lang.reflect.Method m=Class.forName("org.netbeans.modules.rmi.RemoteDetectionSupport").getDeclaredMethod("markRMI",c);
    14.6          m.setAccessible(true);
    14.7 -        Object o[]={jdo,new Boolean(set)};
    14.8 +        Object o[]={jdo,set ? Boolean.TRUE : Boolean.FALSE};
    14.9          m.invoke(null,o);
   14.10      }
   14.11      
    15.1 --- a/vcs.advanced/src/org/netbeans/modules/vcs/advanced/CommandLineVcsFileSystem.java	Sat Sep 14 18:48:21 2002 +0000
    15.2 +++ b/vcs.advanced/src/org/netbeans/modules/vcs/advanced/CommandLineVcsFileSystem.java	Sun Sep 15 20:22:33 2002 +0000
    15.3 @@ -611,7 +611,7 @@
    15.4              this.shortFileStatuses = shortFileStatuses;
    15.5              setPossibleFileStatusesFromVars();
    15.6              refreshStatusOfExistingFiles();
    15.7 -            firePropertyChange(PROP_SHORT_FILE_STATUSES, new Boolean(!shortFileStatuses), new Boolean(shortFileStatuses));
    15.8 +            firePropertyChange(PROP_SHORT_FILE_STATUSES, !shortFileStatuses ? Boolean.TRUE : Boolean.FALSE, shortFileStatuses ? Boolean.TRUE : Boolean.FALSE);
    15.9          }
   15.10      }
   15.11      
    16.1 --- a/vcs.advanced/src/org/netbeans/modules/vcs/advanced/CommandLineVcsFileSystemBeanInfo.java	Sat Sep 14 18:48:21 2002 +0000
    16.2 +++ b/vcs.advanced/src/org/netbeans/modules/vcs/advanced/CommandLineVcsFileSystemBeanInfo.java	Sun Sep 15 20:22:33 2002 +0000
    16.3 @@ -197,7 +197,7 @@
    16.4      public BeanDescriptor getBeanDescriptor() {
    16.5          BeanDescriptor bd = new BeanDescriptor(CommandLineVcsFileSystem.class,
    16.6                                                 org.netbeans.modules.vcs.advanced.VcsCustomizer.class);
    16.7 -        bd.setValue(VcsFileSystem.VCS_PROVIDER_ATTRIBUTE, new Boolean(true));
    16.8 +        bd.setValue(VcsFileSystem.VCS_PROVIDER_ATTRIBUTE, Boolean.TRUE);
    16.9          bd.setValue(VcsFileSystem.VCS_FILESYSTEM_ICON_BASE, "org/netbeans/modules/vcs/advanced/vcsGeneric"); // NOI18N
   16.10          bd.setValue ("helpID", CommandLineVcsFileSystem.class.getName ()); // NOI18N
   16.11          bd.setValue ("propertiesHelpID", CommandLineVcsFileSystem.class.getName() + "_properties"); // NOI18N
    17.1 --- a/vcs.advanced/src/org/netbeans/modules/vcs/advanced/VcsCustomizer.java	Sat Sep 14 18:48:21 2002 +0000
    17.2 +++ b/vcs.advanced/src/org/netbeans/modules/vcs/advanced/VcsCustomizer.java	Sun Sep 15 20:22:33 2002 +0000
    17.3 @@ -1822,7 +1822,7 @@
    17.4          for (Iterator envVars = systemEnvVars.keySet().iterator(); envVars.hasNext(); row++) {
    17.5              String name = (String) envVars.next();
    17.6              String value = (String) systemEnvVars.get(name);
    17.7 -            ((javax.swing.table.DefaultTableModel) systemEnvTableModel.getModel()).addRow(new Object[] { name, value, new Boolean(!envVariablesRemovedSet.contains(name)) });
    17.8 +            ((javax.swing.table.DefaultTableModel) systemEnvTableModel.getModel()).addRow(new Object[] { name, value, !envVariablesRemovedSet.contains(name) ? Boolean.TRUE : Boolean.FALSE });
    17.9              javax.swing.table.TableCellEditor editor = systemEnvTable.getCellEditor(row, 2);
   17.10              editor.addCellEditorListener(new SystemEnvCellEditorListener(name, row, 2));
   17.11          }
    18.1 --- a/vcs.advanced/src/org/netbeans/modules/vcs/advanced/commands/UserCommandIOCompat.java	Sat Sep 14 18:48:21 2002 +0000
    18.2 +++ b/vcs.advanced/src/org/netbeans/modules/vcs/advanced/commands/UserCommandIOCompat.java	Sun Sep 15 20:22:33 2002 +0000
    18.3 @@ -158,9 +158,9 @@
    18.4                  Object oldValue = vc.getProperty(attrName);
    18.5                  if (oldValue instanceof Boolean) {
    18.6                      if (attrValue.equalsIgnoreCase("TRUE")) {
    18.7 -                        value = new Boolean(true);
    18.8 +                        value = Boolean.TRUE;
    18.9                      } else if (attrValue.equalsIgnoreCase("FALSE")) {
   18.10 -                        value = new Boolean(false);
   18.11 +                        value = Boolean.FALSE;
   18.12                      } else {
   18.13                          value = null;
   18.14                      }
   18.15 @@ -199,14 +199,14 @@
   18.16              if (VcsCommand.PROPERTY_ON_ROOT.equals(attrName)) {
   18.17                  if (VcsCommandIO.getBooleanPropertyAssumeTrue(vc, VcsCommand.PROPERTY_ON_DIR)) {
   18.18                      if (Boolean.TRUE.equals(value)) {
   18.19 -                        vc.setProperty(VcsCommand.PROPERTY_ON_DIR, new Boolean(false));
   18.20 -                        vc.setProperty(VcsCommand.PROPERTY_ON_FILE, new Boolean(false));
   18.21 +                        vc.setProperty(VcsCommand.PROPERTY_ON_DIR, Boolean.FALSE);
   18.22 +                        vc.setProperty(VcsCommand.PROPERTY_ON_FILE, Boolean.FALSE);
   18.23                      }
   18.24 -                    value = new Boolean(true);
   18.25 +                    value = Boolean.TRUE;
   18.26                  }
   18.27              }
   18.28              if (VcsCommand.PROPERTY_ON_DIR.equals(attrName)) {
   18.29 -                vc.setProperty(VcsCommand.PROPERTY_ON_ROOT, new Boolean(true));
   18.30 +                vc.setProperty(VcsCommand.PROPERTY_ON_ROOT, Boolean.TRUE);
   18.31              }
   18.32              vc.setProperty(attrName, value);
   18.33              //System.out.println("setting property of '"+vc+"': "+attrName+" = '"+value+"'");
    19.1 --- a/vcs.advanced/src/org/netbeans/modules/vcs/advanced/variables/AccessoryVariableNode.java	Sat Sep 14 18:48:21 2002 +0000
    19.2 +++ b/vcs.advanced/src/org/netbeans/modules/vcs/advanced/variables/AccessoryVariableNode.java	Sun Sep 15 20:22:33 2002 +0000
    19.3 @@ -279,7 +279,7 @@
    19.4                  if (VcsCustomizer.VAR_CONFIG_INPUT_DESCRIPTOR.equals(var.getName())) {
    19.5                      ((AccessoryVariableNode) AccessoryVariableNode.this.getParentNode()).fireVariablePropertyChange(
    19.6                          UserVariablesPanel.PROP_CONFIG_INPUT_DESCRIPTOR,
    19.7 -                        Boolean.FALSE, new Boolean(UserVariablesPanel.isConfigInputDescriptorVar(var)));
    19.8 +                        Boolean.FALSE, UserVariablesPanel.isConfigInputDescriptorVar(var) ? Boolean.TRUE : Boolean.FALSE);
    19.9                  }
   19.10                  //cmd.fireChanged();
   19.11              }
    20.1 --- a/vcs.advanced/src/org/netbeans/modules/vcs/advanced/variables/BasicVariableNode.java	Sat Sep 14 18:48:21 2002 +0000
    20.2 +++ b/vcs.advanced/src/org/netbeans/modules/vcs/advanced/variables/BasicVariableNode.java	Sun Sep 15 20:22:33 2002 +0000
    20.3 @@ -393,7 +393,7 @@
    20.4          set.put(new PropertySupport.ReadWrite("localFile", Boolean.TYPE, g("CTL_LocalFile"), g("HINT_LocalFile")) {
    20.5              public Object getValue() {
    20.6                  //System.out.println("getName: cmd = "+cmd);
    20.7 -                return new Boolean(var.isLocalFile());
    20.8 +                return var.isLocalFile() ? Boolean.TRUE : Boolean.FALSE;
    20.9              }
   20.10              
   20.11              public void setValue(Object value) {
   20.12 @@ -404,7 +404,7 @@
   20.13          set.put(new PropertySupport.ReadWrite("localDir", Boolean.TYPE, g("CTL_LocalDir"), g("HINT_LocalDir")) {
   20.14              public Object getValue() {
   20.15                  //System.out.println("getName: cmd = "+cmd);
   20.16 -                return new Boolean(var.isLocalDir());
   20.17 +                return var.isLocalDir() ? Boolean.TRUE : Boolean.FALSE;
   20.18              }
   20.19              
   20.20              public void setValue(Object value) {
    21.1 --- a/vcs.advanced/src/org/netbeans/modules/vcs/profiles/list/AbstractListCommand.java	Sat Sep 14 18:48:21 2002 +0000
    21.2 +++ b/vcs.advanced/src/org/netbeans/modules/vcs/profiles/list/AbstractListCommand.java	Sun Sep 15 20:22:33 2002 +0000
    21.3 @@ -96,7 +96,7 @@
    21.4          cmd.setProperty(UserCommand.PROPERTY_DATA_REGEX, dataRegex);
    21.5          cmd.setProperty(UserCommand.PROPERTY_ERROR_REGEX, errorRegex);
    21.6          // The user should be warned by the wrapper class and not the command itself.
    21.7 -        cmd.setProperty(VcsCommand.PROPERTY_IGNORE_FAIL, new Boolean(true));
    21.8 +        cmd.setProperty(VcsCommand.PROPERTY_IGNORE_FAIL, Boolean.TRUE);
    21.9          VcsCommandExecutor ec = fileSystem.getVcsFactory().getCommandExecutor(cmd, vars);
   21.10          ec.addDataOutputListener(this);
   21.11          if (addErrOut) ec.addDataErrorOutputListener(this);
   21.12 @@ -136,7 +136,7 @@
   21.13          VcsCommand cmd = fileSystem.getCommand(cmdName);
   21.14          if (cmd == null) return ;
   21.15          // The user should be warned by the wrapper class and not the command itself.
   21.16 -        cmd.setProperty(VcsCommand.PROPERTY_IGNORE_FAIL, new Boolean(true));
   21.17 +        cmd.setProperty(VcsCommand.PROPERTY_IGNORE_FAIL, Boolean.TRUE);
   21.18          VcsCommandExecutor ec = fileSystem.getVcsFactory().getCommandExecutor(cmd, vars);
   21.19          if (dataOutputListener != null) ec.addDataOutputListener(dataOutputListener);
   21.20          if (errorOutputListener != null) ec.addDataErrorOutputListener(errorOutputListener);
    22.1 --- a/vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsModuleParser.java	Sat Sep 14 18:48:21 2002 +0000
    22.2 +++ b/vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsModuleParser.java	Sun Sep 15 20:22:33 2002 +0000
    22.3 @@ -96,7 +96,7 @@
    22.4          D.deb("Module definition: "+moduleDef.substring(index));
    22.5          Vector module = new Vector();
    22.6          module.add(moduleDef.trim());
    22.7 -        module.add(new Boolean(alias));
    22.8 +        module.add(alias ? Boolean.TRUE : Boolean.FALSE);
    22.9          modules.put(moduleName, module);
   22.10          D.deb("Have module "+moduleName+", with content:"+module);
   22.11          if (alias) {
    23.1 --- a/vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsWatchStatus.java	Sat Sep 14 18:48:21 2002 +0000
    23.2 +++ b/vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsWatchStatus.java	Sun Sep 15 20:22:33 2002 +0000
    23.3 @@ -77,9 +77,9 @@
    23.4          }
    23.5          String[] elements = new String[3];
    23.6          String watched = buff.toString();
    23.7 -        elements[0] = new Boolean(watched.indexOf(EDIT) > 0).toString();
    23.8 -        elements[1] = new Boolean(watched.indexOf(UNEDIT) > 0).toString();
    23.9 -        elements[2] = new Boolean(watched.indexOf(COMMIT) > 0).toString();
   23.10 +        elements[0] = watched.indexOf(EDIT) > 0 ? "true" : "false"; // NOI18N
   23.11 +        elements[1] = watched.indexOf(UNEDIT) > 0 ? "true" : "false"; // NOI18N
   23.12 +        elements[2] = watched.indexOf(COMMIT) > 0 ? "true" : "false"; // NOI18N
   23.13          stdoutListener.outputData(elements);
   23.14          return true;
   23.15      }
    24.1 --- a/vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/list/CvsListFileCommand.java	Sat Sep 14 18:48:21 2002 +0000
    24.2 +++ b/vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/list/CvsListFileCommand.java	Sun Sep 15 20:22:33 2002 +0000
    24.3 @@ -367,7 +367,7 @@
    24.4          VcsCommand cmd = fileSystem.getCommand(cmdName);
    24.5          if (cmd == null) return ;
    24.6          // The user should be warned by the wrapper class and not the command itself.
    24.7 -        cmd.setProperty(VcsCommand.PROPERTY_IGNORE_FAIL, new Boolean(true));
    24.8 +        cmd.setProperty(VcsCommand.PROPERTY_IGNORE_FAIL, Boolean.TRUE);
    24.9          VcsCommandExecutor ec = fileSystem.getVcsFactory().getCommandExecutor(cmd, vars);
   24.10          if (dataOutputListener != null) ec.addDataOutputListener(dataOutputListener);
   24.11          if (errorOutputListener != null) ec.addDataErrorOutputListener(errorOutputListener);
    25.1 --- a/vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/list/CvsListRecursiveCommand.java	Sat Sep 14 18:48:21 2002 +0000
    25.2 +++ b/vcs.profiles.cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/list/CvsListRecursiveCommand.java	Sun Sep 15 20:22:33 2002 +0000
    25.3 @@ -208,7 +208,7 @@
    25.4          cmd.setProperty(UserCommand.PROPERTY_DATA_REGEX, dataRegex);
    25.5          cmd.setProperty(UserCommand.PROPERTY_ERROR_REGEX, errorRegex);
    25.6          // The user should be warned by the wrapper class and not the command itself.
    25.7 -        cmd.setProperty(VcsCommand.PROPERTY_IGNORE_FAIL, new Boolean(true));
    25.8 +        cmd.setProperty(VcsCommand.PROPERTY_IGNORE_FAIL, Boolean.TRUE);
    25.9           */
   25.10          VcsCommandExecutor ec = fileSystem.getVcsFactory().getCommandExecutor(cmd, vars);
   25.11          ec.addDataOutputListener(new CommandDataOutputListener() {
    26.1 --- a/vcscore/src/org/netbeans/modules/vcscore/VcsAttributes.java	Sat Sep 14 18:48:21 2002 +0000
    26.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/VcsAttributes.java	Sun Sep 15 20:22:33 2002 +0000
    26.3 @@ -354,7 +354,7 @@
    26.4                      }
    26.5                      status &= executors[i].getExitStatus() == VcsCommandExecutor.SUCCEEDED;
    26.6                  }
    26.7 -                descriptor.setValue(VCS_ACTION_DONE, new Boolean(status));
    26.8 +                descriptor.setValue(VCS_ACTION_DONE, status ? Boolean.TRUE : Boolean.FALSE);
    26.9              }
   26.10          });
   26.11      }
    27.1 --- a/vcscore/src/org/netbeans/modules/vcscore/VcsFileSystem.java	Sat Sep 14 18:48:21 2002 +0000
    27.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/VcsFileSystem.java	Sun Sep 15 20:22:33 2002 +0000
    27.3 @@ -393,8 +393,8 @@
    27.4                  variables.add(var);
    27.5                  variablesByName.put(var.getName(), var);
    27.6              }
    27.7 -            var.setValue(new Boolean(lock).toString());
    27.8 -            firePropertyChange(PROP_CALL_LOCK, new Boolean(!lockFilesOn), new Boolean(lockFilesOn));
    27.9 +            var.setValue(lock ? "true" : "false"); // NOI18N
   27.10 +            firePropertyChange(PROP_CALL_LOCK, !lockFilesOn ? Boolean.TRUE : Boolean.FALSE, lockFilesOn ? Boolean.TRUE : Boolean.FALSE);
   27.11          }
   27.12      }
   27.13      public boolean isPromptForLockOn () { return promptForLockOn; }
   27.14 @@ -407,8 +407,8 @@
   27.15                  variables.add(var);
   27.16                  variablesByName.put(var.getName(), var);
   27.17              }
   27.18 -            var.setValue(new Boolean(prompt).toString());
   27.19 -            firePropertyChange(PROP_CALL_LOCK_PROMPT, new Boolean(!promptForLockOn), new Boolean(promptForLockOn));
   27.20 +            var.setValue(prompt ? "true" : "false"); // NOI18N
   27.21 +            firePropertyChange(PROP_CALL_LOCK_PROMPT, !promptForLockOn ? Boolean.TRUE : Boolean.FALSE, promptForLockOn ? Boolean.TRUE : Boolean.FALSE);
   27.22          }
   27.23      }
   27.24      public boolean getAskIfDownloadRecursively () { return askIfDownloadRecursively; }
   27.25 @@ -425,8 +425,8 @@
   27.26                  variables.add(var);
   27.27                  variablesByName.put(var.getName(), var);
   27.28              }
   27.29 -            var.setValue(new Boolean(edit).toString());
   27.30 -            firePropertyChange(PROP_CALL_EDIT, new Boolean(!callEditFilesOn), new Boolean(callEditFilesOn));
   27.31 +            var.setValue(edit ? "true" : "false"); // NOI18N
   27.32 +            firePropertyChange(PROP_CALL_EDIT, !callEditFilesOn ? Boolean.TRUE : Boolean.FALSE, callEditFilesOn ? Boolean.TRUE : Boolean.FALSE);
   27.33          }
   27.34      }
   27.35      public boolean isPromptForEditOn () { return promptForEditOn; }
   27.36 @@ -439,8 +439,8 @@
   27.37                  variables.add(var);
   27.38                  variablesByName.put(var.getName(), var);
   27.39              }
   27.40 -            var.setValue(new Boolean(prompt).toString());
   27.41 -            firePropertyChange(PROP_CALL_EDIT_PROMPT, new Boolean(!promptForEditOn), new Boolean(promptForEditOn));
   27.42 +            var.setValue(prompt ? "true" : "false"); // NOI18N
   27.43 +            firePropertyChange(PROP_CALL_EDIT_PROMPT, !promptForEditOn ? Boolean.TRUE : Boolean.FALSE, promptForEditOn ? Boolean.TRUE : Boolean.FALSE);
   27.44          }
   27.45      }
   27.46      public boolean isUseUnixShell () { return useUnixShell; }
   27.47 @@ -457,7 +457,7 @@
   27.48          if (unixShell != useUnixShell) {
   27.49              useUnixShell = unixShell;
   27.50              last_useUnixShell = unixShell;
   27.51 -            firePropertyChange(PROP_USE_UNIX_SHELL, new Boolean(!unixShell), new Boolean(unixShell));
   27.52 +            firePropertyChange(PROP_USE_UNIX_SHELL, !unixShell ? Boolean.TRUE : Boolean.FALSE, unixShell ? Boolean.TRUE : Boolean.FALSE);
   27.53          }
   27.54      }
   27.55      
   27.56 @@ -498,7 +498,7 @@
   27.57          if (expertMode != this.expertMode) {
   27.58              this.expertMode = expertMode;
   27.59              setAcceptUserParams(expertMode);
   27.60 -            firePropertyChange(PROP_EXPERT_MODE, new Boolean(!expertMode), new Boolean(expertMode));
   27.61 +            firePropertyChange(PROP_EXPERT_MODE, !expertMode ? Boolean.TRUE : Boolean.FALSE, expertMode ? Boolean.TRUE : Boolean.FALSE);
   27.62          }
   27.63      }
   27.64      
   27.65 @@ -509,7 +509,7 @@
   27.66      public void setCommandNotification(boolean commandNotification) {
   27.67          if (commandNotification != this.commandNotification) {
   27.68              this.commandNotification = commandNotification;
   27.69 -            firePropertyChange(PROP_COMMAND_NOTIFICATION, new Boolean(!commandNotification), new Boolean(commandNotification));
   27.70 +            firePropertyChange(PROP_COMMAND_NOTIFICATION, !commandNotification ? Boolean.TRUE : Boolean.FALSE, commandNotification ? Boolean.TRUE : Boolean.FALSE);
   27.71          }
   27.72      }
   27.73      
   27.74 @@ -524,7 +524,7 @@
   27.75      public void setPromptForVarsForEachFile(boolean promptForVarsForEachFile) {
   27.76          if (this.promptForVarsForEachFile != promptForVarsForEachFile) {
   27.77              this.promptForVarsForEachFile = promptForVarsForEachFile;
   27.78 -            firePropertyChange(PROP_PROMPT_FOR_VARS_FOR_EACH_FILE, new Boolean(!promptForVarsForEachFile), new Boolean(promptForVarsForEachFile));
   27.79 +            firePropertyChange(PROP_PROMPT_FOR_VARS_FOR_EACH_FILE, !promptForVarsForEachFile ? Boolean.TRUE : Boolean.FALSE, promptForVarsForEachFile ? Boolean.TRUE : Boolean.FALSE);
   27.80          }
   27.81      }
   27.82      
   27.83 @@ -547,7 +547,7 @@
   27.84          synchronized (this.processUnimportantFiles) {
   27.85              if (processUnimportantFiles != this.processUnimportantFiles.booleanValue()) {
   27.86                  old = this.processUnimportantFiles;
   27.87 -                this.processUnimportantFiles = new Boolean(processUnimportantFiles);
   27.88 +                this.processUnimportantFiles = processUnimportantFiles ? Boolean.TRUE : Boolean.FALSE;
   27.89                  fire = true;
   27.90              }
   27.91          }
   27.92 @@ -619,8 +619,8 @@
   27.93      }
   27.94      
   27.95      public void setCreateBackupFiles(boolean createBackupFiles) {
   27.96 -        if (!new Boolean(createBackupFiles).equals(this.createBackupFiles)) {
   27.97 -            this.createBackupFiles = new Boolean(createBackupFiles);
   27.98 +        if (createBackupFiles != this.createBackupFiles.booleanValue()) {
   27.99 +            this.createBackupFiles = createBackupFiles ? Boolean.TRUE : Boolean.FALSE;
  27.100              firePropertyChange(PROP_CREATE_BACKUP_FILES, null, this.createBackupFiles);
  27.101          }
  27.102      }
  27.103 @@ -634,8 +634,8 @@
  27.104      }
  27.105      
  27.106      public void setFilterBackupFiles(boolean filterBackupFiles) {
  27.107 -        if (!new Boolean(filterBackupFiles).equals(this.filterBackupFiles)) {
  27.108 -            this.filterBackupFiles = new Boolean(filterBackupFiles);
  27.109 +        if (filterBackupFiles != this.filterBackupFiles.booleanValue()) {
  27.110 +            this.filterBackupFiles = filterBackupFiles ? Boolean.TRUE : Boolean.FALSE;
  27.111              firePropertyChange(PROP_FILTER_BACKUP_FILES, null, this.filterBackupFiles);
  27.112          }
  27.113      }
  27.114 @@ -643,7 +643,7 @@
  27.115      public void setOffLine(boolean offLine) {
  27.116          if (offLine != this.offLine) {
  27.117              this.offLine = offLine;
  27.118 -            firePropertyChange (GeneralVcsSettings.PROP_OFFLINE, new Boolean(!offLine), new Boolean(offLine));
  27.119 +            firePropertyChange (GeneralVcsSettings.PROP_OFFLINE, !offLine ? Boolean.TRUE : Boolean.FALSE, offLine ? Boolean.TRUE : Boolean.FALSE);
  27.120          }
  27.121      }
  27.122      
  27.123 @@ -674,7 +674,7 @@
  27.124      public void setHideShadowFiles(boolean hideShadowFiles) {
  27.125          if (hideShadowFiles != this.hideShadowFiles) {
  27.126              this.hideShadowFiles = hideShadowFiles;
  27.127 -            firePropertyChange (GeneralVcsSettings.PROP_HIDE_SHADOW_FILES, new Boolean(!hideShadowFiles), new Boolean(hideShadowFiles));
  27.128 +            firePropertyChange (GeneralVcsSettings.PROP_HIDE_SHADOW_FILES, !hideShadowFiles ? Boolean.TRUE : Boolean.FALSE, hideShadowFiles ? Boolean.TRUE : Boolean.FALSE);
  27.129          }
  27.130      }
  27.131      
  27.132 @@ -1635,8 +1635,8 @@
  27.133      }
  27.134      
  27.135      protected void setCreateRuntimeCommands(boolean createRuntimeCommands) {
  27.136 -        if (!new Boolean(createRuntimeCommands).equals(this.createRuntimeCommands)) {
  27.137 -            this.createRuntimeCommands = new Boolean(createRuntimeCommands);
  27.138 +        if (createRuntimeCommands != this.createRuntimeCommands.booleanValue()) {
  27.139 +            this.createRuntimeCommands = createRuntimeCommands ? Boolean.TRUE : Boolean.FALSE;
  27.140              if (attr instanceof VcsAttributes) {
  27.141                  ((VcsAttributes) attr).setRuntimeCommandsProvider(
  27.142                      (createRuntimeCommands) ? new VcsRuntimeCommandsProvider(this) : null);
  27.143 @@ -1650,8 +1650,8 @@
  27.144      }
  27.145      
  27.146      protected void setCreateVersioningSystem(boolean createVersioningSystem) {
  27.147 -        if (!new Boolean(createVersioningSystem).equals(this.createVersioningSystem)) {
  27.148 -            this.createVersioningSystem = new Boolean(createVersioningSystem);
  27.149 +        if (createVersioningSystem != this.createVersioningSystem.booleanValue()) {
  27.150 +            this.createVersioningSystem = createVersioningSystem ? Boolean.TRUE : Boolean.FALSE;
  27.151              firePropertyChange(PROP_CREATE_VERSIONING_EXPLORER, null, this.createVersioningSystem);
  27.152          }
  27.153      }
  27.154 @@ -1795,7 +1795,7 @@
  27.155      public void setDebug(boolean debug){
  27.156          if (this.debug != debug) {
  27.157              this.debug = debug;
  27.158 -            firePropertyChange(PROP_DEBUG, new Boolean(!debug), new Boolean(debug));
  27.159 +            firePropertyChange(PROP_DEBUG, !debug ? Boolean.TRUE : Boolean.FALSE, debug ? Boolean.TRUE : Boolean.FALSE);
  27.160          }
  27.161      }
  27.162  
  27.163 @@ -2053,7 +2053,7 @@
  27.164      public void setRememberPassword(boolean remember) {
  27.165          if (this.rememberPassword != remember) {
  27.166              this.rememberPassword = remember;
  27.167 -            firePropertyChange(PROP_REMEMBER_PASSWORD, new Boolean(!remember), new Boolean(remember));
  27.168 +            firePropertyChange(PROP_REMEMBER_PASSWORD, !remember ? Boolean.TRUE : Boolean.FALSE, remember ? Boolean.TRUE : Boolean.FALSE);
  27.169          }
  27.170      }
  27.171      
  27.172 @@ -2742,7 +2742,7 @@
  27.173          D.deb("setReadOnly("+flag+")"); // NOI18N
  27.174          if (flag != readOnly) {
  27.175              readOnly = flag;
  27.176 -            firePropertyChange (PROP_READ_ONLY, new Boolean (!flag), new Boolean (flag));
  27.177 +            firePropertyChange (PROP_READ_ONLY, !flag ? Boolean.TRUE : Boolean.FALSE, flag ? Boolean.TRUE : Boolean.FALSE);
  27.178          }
  27.179      }
  27.180  
    28.1 --- a/vcscore/src/org/netbeans/modules/vcscore/VcsVersioningSystem.java	Sat Sep 14 18:48:21 2002 +0000
    28.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/VcsVersioningSystem.java	Sun Sep 15 20:22:33 2002 +0000
    28.3 @@ -204,7 +204,7 @@
    28.4  
    28.5      public void setShowDeadFiles(boolean showDeadFiles) {
    28.6          fileSystem.setShowDeadFiles(showDeadFiles);
    28.7 -        firePropertyChange(PROP_SHOW_DEAD_FILES, new Boolean(!showDeadFiles), new Boolean(showDeadFiles));
    28.8 +        firePropertyChange(PROP_SHOW_DEAD_FILES, !showDeadFiles ? Boolean.TRUE : Boolean.FALSE, showDeadFiles ? Boolean.TRUE : Boolean.FALSE);
    28.9      }
   28.10      
   28.11      public boolean isShowUnimportantFiles() {
   28.12 @@ -214,7 +214,7 @@
   28.13      public void setShowUnimportantFiles(boolean showUnimportantFiles) {
   28.14          if (this.showUnimportantFiles != showUnimportantFiles) {
   28.15              this.showUnimportantFiles = showUnimportantFiles;
   28.16 -            firePropertyChange(PROP_SHOW_UNIMPORTANT_FILES, new Boolean(!showUnimportantFiles), new Boolean(showUnimportantFiles));
   28.17 +            firePropertyChange(PROP_SHOW_UNIMPORTANT_FILES, !showUnimportantFiles ? Boolean.TRUE : Boolean.FALSE, showUnimportantFiles ? Boolean.TRUE : Boolean.FALSE);
   28.18              refreshExistingFolders();
   28.19          }
   28.20      }
   28.21 @@ -226,7 +226,7 @@
   28.22      public void setShowLocalFiles(boolean showLocalFiles) {
   28.23          if (this.showLocalFiles != showLocalFiles) {
   28.24              this.showLocalFiles = showLocalFiles;
   28.25 -            firePropertyChange(PROP_SHOW_LOCAL_FILES, new Boolean(!showLocalFiles), new Boolean(showLocalFiles));
   28.26 +            firePropertyChange(PROP_SHOW_LOCAL_FILES, !showLocalFiles ? Boolean.TRUE : Boolean.FALSE, showLocalFiles ? Boolean.TRUE : Boolean.FALSE);
   28.27              refreshExistingFolders();
   28.28          }
   28.29      }
   28.30 @@ -267,7 +267,7 @@
   28.31      public void setShowMessages(boolean showMessages) {
   28.32          if (this.showMessages != showMessages) {
   28.33              this.showMessages = showMessages;
   28.34 -            firePropertyChange(PROP_SHOW_MESSAGES, new Boolean(!showMessages), new Boolean(showMessages));
   28.35 +            firePropertyChange(PROP_SHOW_MESSAGES, !showMessages ? Boolean.TRUE : Boolean.FALSE, showMessages ? Boolean.TRUE : Boolean.FALSE);
   28.36              redisplayRevisions();
   28.37          }
   28.38      }
    29.1 --- a/vcscore/src/org/netbeans/modules/vcscore/VcsVersioningSystemBeanInfo.java	Sat Sep 14 18:48:21 2002 +0000
    29.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/VcsVersioningSystemBeanInfo.java	Sun Sep 15 20:22:33 2002 +0000
    29.3 @@ -93,7 +93,7 @@
    29.4       */
    29.5      public BeanDescriptor getBeanDescriptor() {
    29.6          BeanDescriptor beanDescriptor = new BeanDescriptor(VcsVersioningSystem.class, null);
    29.7 -        beanDescriptor.setValue(VcsFileSystem.VCS_PROVIDER_ATTRIBUTE, new Boolean(true));
    29.8 +        beanDescriptor.setValue(VcsFileSystem.VCS_PROVIDER_ATTRIBUTE, Boolean.TRUE);
    29.9  	return beanDescriptor;
   29.10      }
   29.11  
    30.1 --- a/vcscore/src/org/netbeans/modules/vcscore/cmdline/UserCommand.java	Sat Sep 14 18:48:21 2002 +0000
    30.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/cmdline/UserCommand.java	Sun Sep 15 20:22:33 2002 +0000
    30.3 @@ -243,7 +243,7 @@
    30.4              Object property = uc.getProperty(properties[i]);
    30.5              Object newProperty;
    30.6              if (property instanceof Boolean) {
    30.7 -                newProperty = new Boolean(((Boolean) property).booleanValue());
    30.8 +                newProperty = property;
    30.9              } else if (property instanceof Integer) {
   30.10                  newProperty = new Integer(((Integer) property).intValue());
   30.11                  /*
   30.12 @@ -566,26 +566,26 @@
   30.13              //setProperty("timeout", new Long(getTimeout()));
   30.14              setProperty(UserCommand.PROPERTY_DATA_REGEX, dataRegex);//getDataRegex());
   30.15              setProperty(UserCommand.PROPERTY_ERROR_REGEX, errorRegex);//getErrorRegex());
   30.16 -            setProperty(VcsCommand.PROPERTY_DISPLAY_PLAIN_OUTPUT, new Boolean(displayOutput));//isDisplayOutput()));
   30.17 -            //setProperty("doRefresh", new Boolean(isDoRefresh())); <- not needed any more
   30.18 +            setProperty(VcsCommand.PROPERTY_DISPLAY_PLAIN_OUTPUT, displayOutput ? Boolean.TRUE : Boolean.FALSE);//isDisplayOutput()));
   30.19 +            //setProperty("doRefresh", isDoRefresh() ? Boolean.TRUE : Boolean.FALSE); <- not needed any more
   30.20              setProperty(VcsCommand.PROPERTY_REFRESH_RECURSIVELY_PATTERN_MATCHED, refreshRecursivelyPattern);//getRefreshRecursivelyPattern());
   30.21 -            setProperty(VcsCommand.PROPERTY_REFRESH_PARENT_FOLDER, new Boolean(doRefresh/*isDoRefresh()*/ && refreshParent));//isRefreshParent()));
   30.22 -            setProperty(VcsCommand.PROPERTY_REFRESH_CURRENT_FOLDER, new Boolean(doRefresh && !refreshParent));
   30.23 -            setProperty(VcsCommand.PROPERTY_CHECK_FOR_MODIFICATIONS, new Boolean(checkForModifications));
   30.24 +            setProperty(VcsCommand.PROPERTY_REFRESH_PARENT_FOLDER, doRefresh/*isDoRefresh()*/ && refreshParent ? Boolean.TRUE : Boolean.FALSE);//isRefreshParent()));
   30.25 +            setProperty(VcsCommand.PROPERTY_REFRESH_CURRENT_FOLDER, doRefresh && !refreshParent ? Boolean.TRUE : Boolean.FALSE);
   30.26 +            setProperty(VcsCommand.PROPERTY_CHECK_FOR_MODIFICATIONS, checkForModifications ? Boolean.TRUE : Boolean.FALSE);
   30.27              if (onRoot == true) onFile = onDir = false; // The meaning has changed. Instead "on root only" it means "on root too".
   30.28              else onRoot = true;                         // if onRoot == false, it means "not on root, but everywhere.
   30.29 -            setProperty(VcsCommand.PROPERTY_ON_FILE, new Boolean(onFile));
   30.30 -            setProperty(VcsCommand.PROPERTY_ON_DIR, new Boolean(onDir));
   30.31 -            setProperty(VcsCommand.PROPERTY_ON_ROOT, new Boolean(onRoot));
   30.32 -            //setProperty(VcsCommand.PROPERTY_NOT_ON_ROOT, new Boolean(notOnRoot));
   30.33 +            setProperty(VcsCommand.PROPERTY_ON_FILE, onFile ? Boolean.TRUE : Boolean.FALSE);
   30.34 +            setProperty(VcsCommand.PROPERTY_ON_DIR, onDir ? Boolean.TRUE : Boolean.FALSE);
   30.35 +            setProperty(VcsCommand.PROPERTY_ON_ROOT, onRoot ? Boolean.TRUE : Boolean.FALSE);
   30.36 +            //setProperty(VcsCommand.PROPERTY_NOT_ON_ROOT, notOnRoot ? Boolean.TRUE : Boolean.FALSE);
   30.37              setProperty(VcsCommand.PROPERTY_CONFIRMATION_MSG, confirmationMsg);
   30.38 -            setProperty(VcsCommand.PROPERTY_PROCESS_ALL_FILES, new Boolean(processAllFiles));
   30.39 +            setProperty(VcsCommand.PROPERTY_PROCESS_ALL_FILES, processAllFiles ? Boolean.TRUE : Boolean.FALSE);
   30.40              setProperty(VcsCommand.PROPERTY_NUM_REVISIONS, new Integer(numRevisions));
   30.41 -            setProperty(VcsCommand.PROPERTY_CHANGING_NUM_REVISIONS, new Boolean(changingNumRevisions));
   30.42 -            setProperty(VcsCommand.PROPERTY_CHANGING_REVISION, new Boolean(changingRevision));
   30.43 +            setProperty(VcsCommand.PROPERTY_CHANGING_NUM_REVISIONS, changingNumRevisions ? Boolean.TRUE : Boolean.FALSE);
   30.44 +            setProperty(VcsCommand.PROPERTY_CHANGING_REVISION, changingRevision ? Boolean.TRUE : Boolean.FALSE);
   30.45              setProperty(VcsCommand.PROPERTY_CHANGED_REVISION_VAR_NAME, changedRevisionVariableName);
   30.46              //setProperty(UserCommand.PROPERTY_PRECOMMANDS, getPreCommandsStr());
   30.47 -            //setProperty(UserCommand.PROPERTY_PRECOMMANDS_EXECUTE, new Boolean(executePreCommands));
   30.48 +            //setProperty(UserCommand.PROPERTY_PRECOMMANDS_EXECUTE, executePreCommands ? Boolean.TRUE : Boolean.FALSE);
   30.49              if (VcsCommand.NAME_REFRESH.equals(name) || VcsCommand.NAME_REFRESH_RECURSIVELY.equals(name)) {
   30.50                  setProperty(UserCommand.PROPERTY_LIST_INDEX_FILE_NAME, new Integer(fileNameIndex));
   30.51                  setProperty(UserCommand.PROPERTY_LIST_INDEX_STATUS, new Integer(statusIndex));
    31.1 --- a/vcscore/src/org/netbeans/modules/vcscore/commands/PreCommandPerformer.java	Sat Sep 14 18:48:21 2002 +0000
    31.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/commands/PreCommandPerformer.java	Sun Sep 15 20:22:33 2002 +0000
    31.3 @@ -190,7 +190,7 @@
    31.4                          pool.kill(rvce);
    31.5                          exitStates.add(Boolean.FALSE);
    31.6                      } else {
    31.7 -                        exitStates.add(new Boolean(rvce.getExitStatus() == VcsCommandExecutor.SUCCEEDED));
    31.8 +                        exitStates.add(rvce.getExitStatus() == VcsCommandExecutor.SUCCEEDED ? Boolean.TRUE : Boolean.FALSE);
    31.9                      }
   31.10                  }
   31.11                  runningExecutors.clear();
    32.1 --- a/vcscore/src/org/netbeans/modules/vcscore/grouping/VcsGroupSettings.java	Sat Sep 14 18:48:21 2002 +0000
    32.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/grouping/VcsGroupSettings.java	Sun Sep 15 20:22:33 2002 +0000
    32.3 @@ -79,7 +79,7 @@
    32.4       * @param showLinks New value of property showLinks.
    32.5       */
    32.6      public void setShowLinks(boolean show) {
    32.7 -        putProperty(PROP_SHOW_LINKS, new Boolean(show), true);
    32.8 +        putProperty(PROP_SHOW_LINKS, show ? Boolean.TRUE : Boolean.FALSE, true);
    32.9      }
   32.10      
   32.11      /** Getter for property autoAddition.
   32.12 @@ -107,7 +107,7 @@
   32.13       * @param disableGroups New value of property disableGroups.
   32.14       */
   32.15      public void setDisableGroups(boolean disableGroups) {
   32.16 -        putProperty(PROP_DISABLE_GROUPS, new Boolean(disableGroups), true);
   32.17 +        putProperty(PROP_DISABLE_GROUPS, disableGroups ? Boolean.TRUE : Boolean.FALSE, true);
   32.18      }
   32.19      
   32.20  }
    33.1 --- a/vcscore/src/org/netbeans/modules/vcscore/settings/GeneralVcsSettings.java	Sat Sep 14 18:48:21 2002 +0000
    33.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/settings/GeneralVcsSettings.java	Sun Sep 15 20:22:33 2002 +0000
    33.3 @@ -81,7 +81,7 @@
    33.4      /** Set whether these settings overide the filesystem settings.
    33.5       */
    33.6      public void setUseGlobal(boolean global) {
    33.7 -        putProperty(PROP_USE_GLOBAL, new Boolean(global), true);
    33.8 +        putProperty(PROP_USE_GLOBAL, global ? Boolean.TRUE : Boolean.FALSE, true);
    33.9     }
   33.10      
   33.11      /** Getter for property offLine.
   33.12 @@ -95,7 +95,7 @@
   33.13       * @param offLine New value of property offLine.
   33.14       */
   33.15      public void setOffLine(boolean newOffLine) {
   33.16 -        putProperty(PROP_OFFLINE, new Boolean(newOffLine), true);
   33.17 +        putProperty(PROP_OFFLINE, newOffLine ? Boolean.TRUE : Boolean.FALSE, true);
   33.18      }
   33.19      
   33.20      /** Getter for property autoRefresh.
   33.21 @@ -117,7 +117,7 @@
   33.22      }
   33.23      
   33.24      public void setAutoDetect(boolean newAutoDetect) {
   33.25 -        putProperty(PROP_AUTO_DETECT, new Boolean(newAutoDetect), true);
   33.26 +        putProperty(PROP_AUTO_DETECT, newAutoDetect ? Boolean.TRUE : Boolean.FALSE, true);
   33.27      }
   33.28      
   33.29      public File getHome() {
   33.30 @@ -163,7 +163,7 @@
   33.31       * Usually these are Locally-Removed, Needs-Checkout files
   33.32       */
   33.33      public void setHideShadowFiles(boolean hide) {
   33.34 -        putProperty(PROP_HIDE_SHADOW_FILES, new Boolean(hide), true);
   33.35 +        putProperty(PROP_HIDE_SHADOW_FILES, hide ? Boolean.TRUE : Boolean.FALSE, true);
   33.36      }
   33.37  
   33.38      /**
   33.39 @@ -221,7 +221,7 @@
   33.40      }
   33.41  
   33.42      public void setWizardSshWarningsDone(boolean done) {
   33.43 -        putProperty(PROP_SSH_WARNINGS_DONE, new Boolean(done));
   33.44 +        putProperty(PROP_SSH_WARNINGS_DONE, done ? Boolean.TRUE : Boolean.FALSE);
   33.45      }
   33.46      
   33.47      public boolean isWizardSshWarningsDone() {
    34.1 --- a/vcscore/src/org/netbeans/modules/vcscore/ui/views/NodesTableView.java	Sat Sep 14 18:48:21 2002 +0000
    34.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/ui/views/NodesTableView.java	Sun Sep 15 20:22:33 2002 +0000
    34.3 @@ -148,8 +148,8 @@
    34.4      * Write view's state to output stream.
    34.5      */
    34.6      public void writeExternal (ObjectOutput out) throws IOException {
    34.7 -        out.writeObject (new Boolean (popupAllowed));
    34.8 -        out.writeObject (new Boolean (traversalAllowed));
    34.9 +        out.writeObject (popupAllowed ? Boolean.TRUE : Boolean.FALSE);
   34.10 +        out.writeObject (traversalAllowed ? Boolean.TRUE : Boolean.FALSE);
   34.11          out.writeObject (compositeAttributeName);
   34.12          // TODO.. write the tableModel??
   34.13      }
    35.1 --- a/vcscore/src/org/netbeans/modules/vcscore/ui/views/SingleNodeView.java	Sat Sep 14 18:48:21 2002 +0000
    35.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/ui/views/SingleNodeView.java	Sun Sep 15 20:22:33 2002 +0000
    35.3 @@ -157,8 +157,8 @@
    35.4      * Write view's state to output stream.
    35.5      */
    35.6      public void writeExternal (ObjectOutput out) throws IOException {
    35.7 -        out.writeObject (new Boolean (popupAllowed));
    35.8 -        out.writeObject (new Boolean (traversalAllowed));
    35.9 +        out.writeObject (popupAllowed ? Boolean.TRUE : Boolean.FALSE);
   35.10 +        out.writeObject (traversalAllowed ? Boolean.TRUE : Boolean.FALSE);
   35.11      }
   35.12  
   35.13      /*
    36.1 --- a/vcscore/src/org/netbeans/modules/vcscore/ui/views/TableView.java	Sat Sep 14 18:48:21 2002 +0000
    36.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/ui/views/TableView.java	Sun Sep 15 20:22:33 2002 +0000
    36.3 @@ -153,8 +153,8 @@
    36.4      * Write view's state to output stream.
    36.5      */
    36.6      public void writeExternal (ObjectOutput out) throws IOException {
    36.7 -        out.writeObject (new Boolean (popupAllowed));
    36.8 -        out.writeObject (new Boolean (traversalAllowed));
    36.9 +        out.writeObject (popupAllowed ? Boolean.TRUE : Boolean.FALSE);
   36.10 +        out.writeObject (traversalAllowed ? Boolean.TRUE : Boolean.FALSE);
   36.11          out.writeObject (compositeAttributeName);
   36.12          // TODO.. write the tableModel??
   36.13      }
    37.1 --- a/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputDialog.java	Sat Sep 14 18:48:21 2002 +0000
    37.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputDialog.java	Sun Sep 15 20:22:33 2002 +0000
    37.3 @@ -1042,10 +1042,10 @@
    37.4          final String[] varsEnabled = (String[]) component.getEnable().toArray(new String[0]);
    37.5          final String[] varsDisabled = (String[]) component.getDisable().toArray(new String[0]);
    37.6          if (varsEnabled.length > 0) {
    37.7 -            varsToEnableDisable.put(varsEnabled, new Boolean(chbox.isSelected()));
    37.8 +            varsToEnableDisable.put(varsEnabled, chbox.isSelected() ? Boolean.TRUE : Boolean.FALSE);
    37.9          }
   37.10          if (varsDisabled.length > 0) {
   37.11 -            varsToEnableDisable.put(varsDisabled, new Boolean(!chbox.isSelected()));
   37.12 +            varsToEnableDisable.put(varsDisabled, !chbox.isSelected() ? Boolean.TRUE : Boolean.FALSE);
   37.13          }
   37.14          chbox.addChangeListener(new ChangeListener() {
   37.15              public void stateChanged(ChangeEvent ev) {
   37.16 @@ -1291,13 +1291,13 @@
   37.17          final String[] varsDisabled = (String[]) component.getDisable().toArray(new String[0]);
   37.18          boolean enabled = defValue.equals(component.getValue());
   37.19          if (componentVars.length > 0) {
   37.20 -            varsToEnableDisable.put(componentVars, new Boolean(enabled));
   37.21 +            varsToEnableDisable.put(componentVars, enabled ? Boolean.TRUE : Boolean.FALSE);
   37.22          }
   37.23          if (varsEnabled.length > 0) {
   37.24 -            varsToEnableDisable.put(varsEnabled, new Boolean(enabled));
   37.25 +            varsToEnableDisable.put(varsEnabled, enabled ? Boolean.TRUE : Boolean.FALSE);
   37.26          }
   37.27          if (varsDisabled.length > 0) {
   37.28 -            varsToEnableDisable.put(varsDisabled, new Boolean(!enabled));
   37.29 +            varsToEnableDisable.put(varsDisabled, !enabled ? Boolean.TRUE : Boolean.FALSE);
   37.30          }
   37.31          button.addChangeListener(new ChangeListener() {
   37.32              public void stateChanged(ChangeEvent ev) {
    38.1 --- a/vcscore/src/org/netbeans/modules/vcscore/util/table/TableInfoModel.java	Sat Sep 14 18:48:21 2002 +0000
    38.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/util/table/TableInfoModel.java	Sun Sep 15 20:22:33 2002 +0000
    38.3 @@ -125,7 +125,7 @@
    38.4        {
    38.5              Integer integ = new Integer(columnNumber);
    38.6              columnLabels.put(integ, label);
    38.7 -            columnSorted.put(integ, new Boolean(sorted));
    38.8 +            columnSorted.put(integ, sorted ? Boolean.TRUE : Boolean.FALSE);
    38.9              columnValueSetters.put(integ, reflectionGetter);
   38.10              columnValueParams.put(integ, null);
   38.11              columnComparators.put(integ, comp);
   38.12 @@ -137,7 +137,7 @@
   38.13        {
   38.14              Integer integ = new Integer(columnNumber);
   38.15              columnLabels.put(integ, label);
   38.16 -            columnSorted.put(integ, new Boolean(sorted));
   38.17 +            columnSorted.put(integ, sorted ? Boolean.TRUE : Boolean.FALSE);
   38.18              columnValueSetters.put(integ, reflectionGetter);
   38.19              columnValueParams.put(integ, params);
   38.20              columnComparators.put(integ, comp);
    39.1 --- a/vcscore/src/org/netbeans/modules/vcscore/versioning/RevisionItem.java	Sat Sep 14 18:48:21 2002 +0000
    39.2 +++ b/vcscore/src/org/netbeans/modules/vcscore/versioning/RevisionItem.java	Sun Sep 15 20:22:33 2002 +0000
    39.3 @@ -177,7 +177,7 @@
    39.4          //System.out.println("RevisionItem("+revision+"): current = "+this.current+", setCurrent("+current+")");
    39.5          if (current != this.current) {
    39.6              this.current = current;
    39.7 -            firePropertyChange(PROP_CURRENT_REVISION, new Boolean(!current), new Boolean(current));
    39.8 +            firePropertyChange(PROP_CURRENT_REVISION, !current ? Boolean.TRUE : Boolean.FALSE, current ? Boolean.TRUE : Boolean.FALSE);
    39.9          }
   39.10      }
   39.11